Avatar billede zidane5 Nybegynder
13. maj 2011 - 21:07 Der er 3 kommentarer og
1 løsning

Hjælp til login system, msql, database

Hej. Jeg er ved at oprette et login system til min hjemmeside. Jeg har oploadet filerne osv og tabellerne er oprettet på msql.

Jeg har dog et lille problem som jeg ikke kan få løst.

jeg får denne fejl:

Warning: mysql_numrows(): supplied argument is not a valid MySQL result resource in /home/oddsxper/public_html/include/database.php on line 225

Jeg har sat XXX ved linie 225, så i kan finde den omkring sidst tredjedel. Håber i kan hjælpe. tak på forhånd.

<?php
/**
* Database.php
*
* The Database class is meant to simplify the task of accessing
* information from the website's database.
*
* jpWare php login system v.1.0.0
* Copyright (C) 2009, Vlad Hristov (www.wonderwebware.com)
* Copyright (C) 2004,2009  entity known as jpmaster77 (www.evolt.org/node/60384) and Ivan Novak (www.ivannovak.com)
* Last Updated: Nov 24, 2009
*/
include("constants.php");
     
class MySQLDB
{
  var $connection;        //The MySQL database connection
  var $num_active_users;  //Number of active users viewing site
  var $num_active_guests;  //Number of active guests viewing site
  var $num_members;        //Number of signed-up users
  /* Note: call getNumMembers() to access $num_members! */

  /* Class constructor */
  function MySQLDB(){
      /* Make connection to database */
      $this->connection = mysql_connect(DB_SERVER, DB_USER, DB_PASS) or die(mysql_error());
      mysql_select_db(DB_NAME, $this->connection) or die(mysql_error());
     
      /**
      * Only query database to find out number of members
      * when getNumMembers() is called for the first time,
      * until then, default value set.
      */
      $this->num_members = -1;
     
      if(TRACK_VISITORS){
        /* Calculate number of users at site */
        $this->calcNumActiveUsers();
     
        /* Calculate number of guests at site */
        $this->calcNumActiveGuests();
      }
  }

  /**
    * confirmUserPass - Checks whether or not the given
    * username is in the database, if so it checks if the
    * given password is the same password in the database
    * for that user. If the user doesn't exist or if the
    * passwords don't match up, it returns an error code
    * (1 or 2). On success it returns 0.
    */
  function confirmUserPass($username, $password){
      /* Add slashes if necessary (for query) */
      if(!get_magic_quotes_gpc()) {
          $username = addslashes($username);
      }

      /* Verify that user is in database */
      $q = "SELECT password FROM ".TBL_USERS." WHERE username = '$username'";
      $result = mysql_query($q, $this->connection);
      if(!$result || (mysql_numrows($result) < 1)){
        return 1; //Indicates username failure
      }

      /* Retrieve password from result, strip slashes */
      $dbarray = mysql_fetch_array($result);
      $dbarray['password'] = stripslashes($dbarray['password']);
      $password = stripslashes($password);

      /* Validate that password is correct */
      if($password == $dbarray['password']){
        return 0; //Success! Username and password confirmed
      }
      else{
        return 2; //Indicates password failure
      }
  }
 
  /**
    * confirmUserID - Checks whether or not the given
    * username is in the database, if so it checks if the
    * given userid is the same userid in the database
    * for that user. If the user doesn't exist or if the
    * userids don't match up, it returns an error code
    * (1 or 2). On success it returns 0.
    */
  function confirmUserID($username, $userid){
      /* Add slashes if necessary (for query) */
      if(!get_magic_quotes_gpc()) {
          $username = addslashes($username);
      }

      /* Verify that user is in database */
      $q = "SELECT userid FROM ".TBL_USERS." WHERE username = '$username'";
      $result = mysql_query($q, $this->connection);
      if(!$result || (mysql_numrows($result) < 1)){
        return 1; //Indicates username failure
      }

      /* Retrieve userid from result, strip slashes */
      $dbarray = mysql_fetch_array($result);
      $dbarray['userid'] = stripslashes($dbarray['userid']);
      $userid = stripslashes($userid);

      /* Validate that userid is correct */
      if($userid == $dbarray['userid']){
        return 0; //Success! Username and userid confirmed
      }
      else{
        return 2; //Indicates userid invalid
      }
  }
 
  /**
    * usernameTaken - Returns true if the username has
    * been taken by another user, false otherwise.
    */
  function usernameTaken($username){
      if(!get_magic_quotes_gpc()){
        $username = addslashes($username);
      }
      $q = "SELECT username FROM ".TBL_USERS." WHERE username = '$username'";
      $result = mysql_query($q, $this->connection);
      return (mysql_numrows($result) > 0);
  }
 
 
  /**
    * emailTaken - Returns true if the email has
    * been taken by another user, false otherwise.
    */
    function emailTaken($email){
      if(!get_magic_quotes_gpc()){
          $email = addslashes($email);
      }
      $q = "SELECT email FROM ".TBL_USERS." WHERE email = '$email'";
      $result = mysql_query($q, $this->connection);
      return (mysql_num_rows($result) > 0);
    }
   
  /**
    * usernameBanned - Returns true if the username has
    * been banned by the administrator.
    */
  function usernameBanned($username){
      if(!get_magic_quotes_gpc()){
        $username = addslashes($username);
      }
      $q = "SELECT username FROM ".TBL_BANNED_USERS." WHERE username = '$username'";
      $result = mysql_query($q, $this->connection);
      return (mysql_numrows($result) > 0);
  }
 
  /**
    * addNewUser - Inserts the given (username, password, email)
    * info into the database. Appropriate user level is set.
    * Returns true on success, false otherwise.
    */
  function addNewUser($username, $password, $email, $userid, $name){
      $time = time();
      /* If admin sign up, give admin user level */
      if(strcasecmp($username, ADMIN_NAME) == 0){
        $ulevel = ADMIN_LEVEL;
      }else{
        $ulevel = USER_LEVEL;
      }
      if(CONFIRMATION_REQUIRED){ $valid='1'; } else { $valid='0'; }
      if($username==ADMIN_NAME){$valid='1';} //master admin user autoconfirmed to avid missed email or something like that!
      $q = "INSERT INTO ".TBL_USERS." VALUES ('$username', '$password', '$userid', $ulevel, '$email', $time, ".$valid.", '$name')";
      return mysql_query($q, $this->connection);
  }
 
  /**
    * updateUserField - Updates a field, specified by the field
    * parameter, in the user's row of the database.
    */
  function updateUserField($username, $field, $value){
      $q = "UPDATE ".TBL_USERS." SET ".$field." = '$value' WHERE username = '$username'";
      return mysql_query($q, $this->connection);
  }
 
  /**
    * getUserInfo - Returns the result array from a mysql
    * query asking for all information stored regarding
    * the given username. If query fails, NULL is returned.
    */
  function getUserInfo($username){
      $q = "SELECT * FROM ".TBL_USERS." WHERE username = '$username'";
      $result = mysql_query($q, $this->connection);
      /* Error occurred, return given name by default */
      if(!$result || (mysql_numrows($result) < 1)){
        return NULL;
      }
      /* Return result array */
      $dbarray = mysql_fetch_array($result);
      return $dbarray;
  }
 
  /**
    * getNumMembers - Returns the number of signed-up users
    * of the website, banned members not included. The first
    * time the function is called on page load, the database
    * is queried, on subsequent calls, the stored result
    * is returned. This is to improve efficiency, effectively
    * not querying the database when no call is made.
    */
  function getNumMembers(){
      if($this->num_members < 0){
        $q = "SELECT * FROM ".TBL_USERS;
        $result = mysql_query($q, $this->connection);
        $this->num_members = mysql_numrows($result);
      }
      return $this->num_members;
  }
 
  /**
    * calcNumActiveUsers - Finds out how many active users
    * are viewing site and sets class variable accordingly.
    */
  function calcNumActiveUsers(){
      /* Calculate number of users at site */
      $q = "SELECT * FROM ".TBL_ACTIVE_USERS;

XXX  $result = mysql_query($q, $this->connection);

      $this->num_active_users = mysql_numrows($result);
  }
 
  /**
    * calcNumActiveGuests - Finds out how many active guests
    * are viewing site and sets class variable accordingly.
    */
  function calcNumActiveGuests(){
      /* Calculate number of guests at site */
      $q = "SELECT * FROM ".TBL_ACTIVE_GUESTS;
      $result = mysql_query($q, $this->connection);
      $this->num_active_guests = mysql_numrows($result);
  }
 
  /**
    * addActiveUser - Updates username's last active timestamp
    * in the database, and also adds him to the table of
    * active users, or updates timestamp if already there.
    */
  function addActiveUser($username, $time){
      $q = "UPDATE ".TBL_USERS." SET timestamp = '$time' WHERE username = '$username'";
      mysql_query($q, $this->connection);
     
      if(!TRACK_VISITORS) return;
      $q = "REPLACE INTO ".TBL_ACTIVE_USERS." VALUES ('$username', '$time')";
      mysql_query($q, $this->connection);
      $this->calcNumActiveUsers();
  }
 
  /* addActiveGuest - Adds guest to active guests table */
  function addActiveGuest($ip, $time){
      if(!TRACK_VISITORS) return;
      $q = "REPLACE INTO ".TBL_ACTIVE_GUESTS." VALUES ('$ip', '$time')";
      mysql_query($q, $this->connection);
      $this->calcNumActiveGuests();
  }
 
  /* These functions are self explanatory, no need for comments */
 
  /* removeActiveUser */
  function removeActiveUser($username){
      if(!TRACK_VISITORS) return;
      $q = "DELETE FROM ".TBL_ACTIVE_USERS." WHERE username = '$username'";
      mysql_query($q, $this->connection);
      $this->calcNumActiveUsers();
  }
 
  /* removeActiveGuest */
  function removeActiveGuest($ip){
      if(!TRACK_VISITORS) return;
      $q = "DELETE FROM ".TBL_ACTIVE_GUESTS." WHERE ip = '$ip'";
      mysql_query($q, $this->connection);
      $this->calcNumActiveGuests();
  }
 
  /* removeInactiveUsers */
  function removeInactiveUsers(){
      if(!TRACK_VISITORS) return;
      $timeout = time()-USER_TIMEOUT*60;
      $q = "DELETE FROM ".TBL_ACTIVE_USERS." WHERE timestamp < $timeout";
      mysql_query($q, $this->connection);
      $this->calcNumActiveUsers();
  }

  /* removeInactiveGuests */
  function removeInactiveGuests(){
      if(!TRACK_VISITORS) return;
      $timeout = time()-GUEST_TIMEOUT*60;
      $q = "DELETE FROM ".TBL_ACTIVE_GUESTS." WHERE timestamp < $timeout";
      mysql_query($q, $this->connection);
      $this->calcNumActiveGuests();
  }
 
  /**
    * query - Performs the given query on the database and
    * returns the result, which may be false, true or a
    * resource identifier.
    */
  function query($query){
      return mysql_query($query, $this->connection);
  }
};

/* Create database connection */
$database = new MySQLDB;

?>
14. maj 2011 - 00:01 #1
Jeg citerer fra http://php.net/manual/en/function.mysql-query.php:

For SELECT, SHOW, DESCRIBE, EXPLAIN and other statements returning resultset, mysql_query() returns a resource on success, or FALSE on error.

Saa hvis $result ikke er 'a valid resource' efter $result = mysql_query("select * from" .TBL_ACTIVE_USERS) saa maa $result vaere FALSE, og queryen er fejlagtigt.  En aarsag kan vaere at der endnu ikke er noget indhold i TBL_ACTIVE_USERS paa det tidspunkt du koerer koden.  Jeg foreslaar at du tester for dette, for eksempel saaledes:

$q = "SELECT * FROM ".TBL_ACTIVE_USERS;
$result = mysql_query($q, $this->connection);
if(mysql_num_rows($result) > 0) $this->num_active_users = mysql_numrows($result);
else $this->num_active_users = 0;

Fodnote:  Jeg kender ikke kommandoen mysql_numrows() som du bruger i din kode.  Hvis det virker er det godt.  Ellers skal du ifoelge http://be.php.net/manual/en/function.msql-numrows.php enten bruge mysql_num_rows() eller msql_numrows().
Avatar billede zidane5 Nybegynder
15. maj 2011 - 21:52 #2
Taj for svaret :D
15. maj 2011 - 22:18 #3
Lukker du spoergsmaalet og afgiver det lovede points?  Jeg ser at dette er dit foerste spoergsmaal paa Eksperten, saa lad mig forklare (maaske til overflod):  For at lukke spoergsmaalet og afgive points skal du saette et 'flueben' i den lille firkant 'Accepter dette svar' og derefter klikke paa feltet 'Accepter svar og afgiv points.'
15. maj 2011 - 22:21 #4
Naar du har lukket dette spoergsmaal kan jeg kikke paa det naeste spoergsmaal du oprettede.
Avatar billede Ny bruger Nybegynder

Din løsning...

Tilladte BB-code-tags: [b]fed[/b] [i]kursiv[/i] [u]understreget[/u] Web- og emailadresser omdannes automatisk til links. Der sættes "nofollow" på alle links.

Loading billede Opret Preview
Kategori
Computerworld tilbyder specialiserede kurser i database-management

Log ind eller opret profil

Hov!

For at kunne deltage på Computerworld Eksperten skal du være logget ind.

Det er heldigvis nemt at oprette en bruger: Det tager to minutter og du kan vælge at bruge enten e-mail, Facebook eller Google som login.

Du kan også logge ind via nedenstående tjenester